Remove use of implicit NLSolversBase.value and NLSolversBase.gradient
#190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
commented
Nov 26, 2025
devmotion
commented
Nov 26, 2025
devmotion
force-pushed
the
dmw/remove_implicit
branch
from
c5b60cd to
3a1511e
Compare
pkofod
reviewed
Nov 26, 2025
| state.alpha = _hzI0(state.x, NLSolversBase.gradient(df), | ||
| NLSolversBase.value(df), | ||
| # phi_0 is (or should be) equal to NLSolversBase.value(df, state.x) | ||
| # TODO: Make the gradient available as part of the state? |
Member
There was a problem hiding this comment.
yes, generally only g_previous is available with the logic being that we can use the cache in the objective, but as we have discussed it makes sense to add an additional vector/array to the algorithm state because it's so much easier to ensure correctness that way. One more array won't mean anything in the full scheme
pkofod
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #187